Speed up the pixels to page bytes conversion#2
Open
Tey wants to merge 1 commit intoBLavery:masterfrom
Open
Conversation
Owner
|
Thanks Tey,
I'm not in a position to look at this just now. Away from home (Australia),
wandering around the north-east of Mexico. Won't be home until late
January. If you wanted to fork the whole thing yourself, feel free. Or we
can wait.
The process of PULL to incorporating contributed changes I have not ever
tried to master, and I don't have leisure to attempt it from here.
Regards
Brian
…On 9 December 2016 at 05:20, Tey ***@***.***> wrote:
First, thanks for your work on that lib!
These changes should improve the speed of the ssd1306.display() method.
My testings indicate they speed up the conversion by a 2x factor, so you
might want to apply them.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Speed up the pixels to page bytes conversion
File Changes
- *M* lib_oled96.py
<https://github.com/BLavery/lib_oled96/pull/2/files#diff-0> (21)
Patch Links:
- https://github.com/BLavery/lib_oled96/pull/2.patch
- https://github.com/BLavery/lib_oled96/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIYX1YX7n0OZ-88EAinyxSBJS36UFbsuks5rGStjgaJpZM4LIyC6>
.
|
Author
|
No problem, there's no hurry. If you need help to understand how pull requests work, just ask :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks for your work on that lib!
These changes should improve the speed of the
ssd1306.display()method. My testings indicate they speed up the conversion by a 2x factor, so you might want to apply them. They don't double the FPS though, but I'm able to get 25 FPS with them which was not possible with original implementation.